scsi: ibmvfc: fix misdefined reserved field in ibmvfc_fcp_rsp_info
authorTyrel Datwyler <>
Wed, 24 Jan 2018 02:11:32 +0000 (20:11 -0600)
committerBen Hutchings <>
Thu, 31 May 2018 23:30:11 +0000 (00:30 +0100)
commit c39813652700f3df552b6557530f1e5f782dbe2f upstream.

The fcp_rsp_info structure as defined in the FC spec has an initial 3
bytes reserved field. The ibmvfc driver mistakenly defined this field as
4 bytes resulting in the rsp_code field being defined in what should be
the start of the second reserved field and thus always being reported as
zero by the driver.

Ideally, we should wire ibmvfc up with libfc for the sake of code
deduplication, and ease of maintaining standardized structures in a
single place. However, for now simply fixup the definition in ibmvfc for
backporting to distros on older kernels. Wiring up with libfc will be
done in a followup patch.

Reported-by: Hannes Reinecke <>
Signed-off-by: Tyrel Datwyler <>
Signed-off-by: Martin K. Petersen <>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <>

index 834c37f..b187a6f 100644 (file)
@@ -365,7 +365,7 @@ enum ibmvfc_fcp_rsp_info_codes {
 struct ibmvfc_fcp_rsp_info {
-       u16 reserved;
+       u8 reserved[3];
        u8 rsp_code;
        u8 reserved2[4];
 }__attribute__((packed, aligned (2)));