ext3: remove an unneeded check in ext3_new_blocks()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 25 Feb 2014 08:39:45 +0000 (11:39 +0300)
committerJan Kara <jack@suse.cz>
Mon, 3 Mar 2014 10:31:01 +0000 (11:31 +0100)
We know "fatal" is zero here.  The code can be simplified a bit by
assigning directly.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/ext3/balloc.c

index 22548f5..158b5d4 100644 (file)
@@ -1727,10 +1727,7 @@ allocated:
        percpu_counter_sub(&sbi->s_freeblocks_counter, num);
 
        BUFFER_TRACE(gdp_bh, "journal_dirty_metadata for group descriptor");
-       err = ext3_journal_dirty_metadata(handle, gdp_bh);
-       if (!fatal)
-               fatal = err;
-
+       fatal = ext3_journal_dirty_metadata(handle, gdp_bh);
        if (fatal)
                goto out;