ext3: remove unneeded check in ext3_ordered_writepage()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 21 Feb 2014 08:58:54 +0000 (11:58 +0300)
committerJan Kara <jack@suse.cz>
Mon, 3 Mar 2014 10:31:00 +0000 (11:31 +0100)
We already know "ret" is zero so there is no need to do:

if (!ret)
ret = err;

We can just assign ret directly instead.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/ext3/inode.c

index 384b6eb..491f022 100644 (file)
@@ -1673,12 +1673,9 @@ static int ext3_ordered_writepage(struct page *page,
         * block_write_full_page() succeeded.  Otherwise they are unmapped,
         * and generally junk.
         */
-       if (ret == 0) {
-               err = walk_page_buffers(handle, page_bufs, 0, PAGE_CACHE_SIZE,
+       if (ret == 0)
+               ret = walk_page_buffers(handle, page_bufs, 0, PAGE_CACHE_SIZE,
                                        NULL, journal_dirty_data_fn);
-               if (!ret)
-                       ret = err;
-       }
        walk_page_buffers(handle, page_bufs, 0,
                        PAGE_CACHE_SIZE, NULL, bput_one);
        err = ext3_journal_stop(handle);