ALSA: hda - Fix memory leaks at error path in patch_cirrus.c

commit c5e0b6dbad9b4d18c561af90b384d02373f1c994 upstream.

The proper destructor should be called at the error path.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
[bwh: Backported to 3.2: drop the change to nonexistent patch_cs4213()]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

diff --git a/sound/pci/hda/patch_cirrus.c b/sound/pci/hda/patch_cirrus.c
index ec0518e..e449278 100644 (file)
--- a/sound/pci/hda/patch_cirrus.c
+++ b/sound/pci/hda/patch_cirrus.c
@@ -1404,7 +1404,7 @@ static int patch_cs420x(struct hda_codec *codec)
        return 0;
 
  error:
        return 0;
 
  error:

-       kfree(codec->spec);
+       cs_free(codec);

        codec->spec = NULL;
        return err;
 }
        codec->spec = NULL;
        return err;
 }


@@ -1949,7 +1949,7 @@ static int patch_cs421x(struct hda_codec *codec)
        return 0;
 
  error:
        return 0;
 
  error:

-       kfree(codec->spec);
+       cs_free(codec);

        codec->spec = NULL;
        return err;
 }
        codec->spec = NULL;
        return err;
 }