mac80211_hwsim: Add missing check for HWSIM_ATTR_SIGNAL
authorMartin Willi <martin@strongswan.org>
Fri, 13 May 2016 10:41:48 +0000 (12:41 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 22 Aug 2016 21:37:12 +0000 (22:37 +0100)
commit19c605df59761f2e65389ab444c5696aaf666cca
treec5a471f31eb8ad5150853571eaf0721f6d1fc997
parent0ab9b883b36507e4ca4e5a0883fcca25c8a9e32c
mac80211_hwsim: Add missing check for HWSIM_ATTR_SIGNAL

commit 62397da50bb20a6b812c949ef465d7e69fe54bb6 upstream.

A wmediumd that does not send this attribute causes a NULL pointer
dereference, as the attribute is accessed even if it does not exist.

The attribute was required but never checked ever since userspace frame
forwarding has been introduced. The issue gets more problematic once we
allow wmediumd registration from user namespaces.

Fixes: 7882513bacb1 ("mac80211_hwsim driver support userspace frame tx/rx")
Signed-off-by: Martin Willi <martin@strongswan.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
[bwh: Backported to 3.2: adjust context, indentation]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/wireless/mac80211_hwsim.c