led: Fixed setting of STATUS_LED_BIT1 when led_name is 'all'
authorJoel A Fernandes <agnel.joel@gmail.com>
Fri, 12 Aug 2011 00:10:19 +0000 (19:10 -0500)
committerAlbert ARIBAUD <albert.u.boot@aribaud.net>
Sun, 4 Sep 2011 09:36:22 +0000 (11:36 +0200)
Fix for only one led getting set or reset when the led_name is 'all'

Previous discussion:
http://lists.denx.de/pipermail/u-boot/2011-May/093068.html

Changes since v1:
Fixed checkpatch if statement error noticed by Sergei.

Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
Signed-off-by: Jason Kridner <jkridner@beagleboard.org>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
common/cmd_led.c

index d14dd5a..183dc0b 100644 (file)
@@ -108,7 +108,9 @@ int do_led (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
                        } else {
                                __led_set(led_commands[i].mask, state);
                        }
-                       break;
+                       /* Need to set only 1 led if led_name wasn't 'all' */
+                       if (strcmp("all", argv[1]) != 0)
+                               break;
                }
        }