staging: brcm80211: use kstrdup()

 Use kstrdup rather than duplicating its implementation

 The semantic patch that makes this output is available
 in scripts/coccinelle/api/kstrdup.cocci.

 More information about semantic patching is available at
 http://coccinelle.lip6.fr/

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_common.c b/drivers/staging/brcm80211/brcmfmac/dhd_common.c
index a6704c4..bd655a3 100644 (file)
--- a/drivers/staging/brcm80211/brcmfmac/dhd_common.c
+++ b/drivers/staging/brcm80211/brcmfmac/dhd_common.c
@@ -928,7 +928,7 @@ void brcmf_c_pktfilter_offload_set(struct brcmf_pub *drvr, char *arg)
        int i = 0;
        char *arg_save = 0, *arg_org = 0;
 
-       arg_save = kmalloc(strlen(arg) + 1, GFP_ATOMIC);
+       arg_save = kstrdup(arg, GFP_ATOMIC);
        if (!arg_save) {
                BRCMF_ERROR(("%s: kmalloc failed\n", __func__));
                goto fail;
@@ -942,8 +942,6 @@ void brcmf_c_pktfilter_offload_set(struct brcmf_pub *drvr, char *arg)
                goto fail;
        }
 
-       strcpy(arg_save, arg);
-
        argv[i] = strsep(&arg_save, " ");
        while (argv[i++])
                argv[i] = strsep(&arg_save, " ");