b43: Don't use memcpy for overlapping areas

It is valid to pass &gphy->rfatt and &gphy->bbatt as rfatt and bbatt
pointer arguments to the function. So we have to use memmove for the
possibly overlapping memory areas.

Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

diff --git a/drivers/net/wireless/b43/phy_g.c b/drivers/net/wireless/b43/phy_g.c
index fce8489..063db5c 100644 (file)
--- a/drivers/net/wireless/b43/phy_g.c
+++ b/drivers/net/wireless/b43/phy_g.c
@@ -232,11 +232,12 @@ void b43_set_txpower_g(struct b43_wldev *dev,
        if (unlikely(tx_bias == 0xFF))
                tx_bias = 0;
 
-       /* Save the values for later */
+       /* Save the values for later. Use memmove, because it's valid
+        * to pass &gphy->rfatt as rfatt pointer argument. Same for bbatt. */
        gphy->tx_control = tx_control;
-       memcpy(&gphy->rfatt, rfatt, sizeof(*rfatt));
+       memmove(&gphy->rfatt, rfatt, sizeof(*rfatt));
        gphy->rfatt.with_padmix = !!(tx_control & B43_TXCTL_TXMIX);
-       memcpy(&gphy->bbatt, bbatt, sizeof(*bbatt));
+       memmove(&gphy->bbatt, bbatt, sizeof(*bbatt));
 
        if (b43_debug(dev, B43_DBG_XMITPOWER)) {
                b43dbg(dev->wl, "Tuning TX-power to bbatt(%u), "