task_work: add a scheduling point in task_work_run()
authorEric Dumazet <edumazet@google.com>
Tue, 21 Aug 2012 13:05:14 +0000 (15:05 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 21 Aug 2012 16:11:44 +0000 (09:11 -0700)
It seems commit 4a9d4b024a31 ("switch fput to task_work_add") re-
introduced the problem addressed in 944be0b22472 ("close_files(): add
scheduling point")

If a server process with a lot of files (say 2 million tcp sockets) is
killed, we can spend a lot of time in task_work_run() and trigger a soft
lockup.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/task_work.c

index 91d4e17..d320d44 100644 (file)
@@ -75,6 +75,7 @@ void task_work_run(void)
                        p = q->next;
                        q->func(q);
                        q = p;
+                       cond_resched();
                }
        }
 }