Staging: bcm: return -EFAULT on copy_to_user() errors
authorDan Carpenter <error27@gmail.com>
Fri, 8 Oct 2010 12:56:58 +0000 (14:56 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 8 Oct 2010 14:29:56 +0000 (07:29 -0700)
bcm/InterfaceDld.c had a couple places which returned the number of
bytes remaining instead of -EFAULT.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/bcm/InterfaceDld.c

index 8825b8e..60c0f29 100644 (file)
@@ -167,7 +167,7 @@ static int bcm_download_config_file(PMINI_ADAPTER Adapter,
        {
                bcm_kfree (Adapter->pstargetparams);
                Adapter->pstargetparams = NULL;
-               return retval;
+               return -EFAULT;
        }
        /* Parse the structure and then Download the Firmware */
        beceem_parse_target_struct(Adapter);
@@ -385,6 +385,7 @@ int bcm_ioctl_fw_download(PMINI_ADAPTER Adapter, FIRMWARE_INFO *psFwInfo)
                if(retval != STATUS_SUCCESS)
                {
                        BCM_DEBUG_PRINT(Adapter,DBG_TYPE_INITEXIT, MP_INIT, DBG_LVL_ALL, "copying buffer from user space failed");
+                       retval = -EFAULT;
                        goto error ;
                }