mfd: sta2x11-mfd: Fix return value check in sta2x11_mfd_platform_probe()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Sat, 7 Dec 2013 06:03:00 +0000 (14:03 +0800)
committerLee Jones <lee.jones@linaro.org>
Tue, 21 Jan 2014 08:28:03 +0000 (08:28 +0000)
In case of error, the function devm_regmap_init_mmio() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/sta2x11-mfd.c

index 53ab686..0d42e40 100644 (file)
@@ -339,7 +339,7 @@ static int sta2x11_mfd_platform_probe(struct platform_device *dev,
        regmap_config->cache_type = REGCACHE_NONE;
        mfd->regmap[index] = devm_regmap_init_mmio(&dev->dev, mfd->regs[index],
                                                   regmap_config);
-       WARN_ON(!mfd->regmap[index]);
+       WARN_ON(IS_ERR(mfd->regmap[index]));
 
        return 0;
 }