regulator: max8952 - fix max8952_set_voltage
authorAxel Lin <axel.lin@gmail.com>
Mon, 25 Oct 2010 23:55:54 +0000 (07:55 +0800)
committerLiam Girdwood <lrg@slimlogic.co.uk>
Thu, 28 Oct 2010 21:40:32 +0000 (22:40 +0100)
In current implementation, vid is declared as u8,
then "vid == -1" is always false, and "vid >= 0" is always true.
Thus change it to s8.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
drivers/regulator/max8952.c

index 7d6aacf..0d5dda4 100644 (file)
@@ -136,7 +136,7 @@ static int max8952_set_voltage(struct regulator_dev *rdev,
                                int min_uV, int max_uV)
 {
        struct max8952_data *max8952 = rdev_get_drvdata(rdev);
-       u8 vid = -1, i;
+       s8 vid = -1, i;
 
        if (!gpio_is_valid(max8952->pdata->gpio_vid0) ||
                        !gpio_is_valid(max8952->pdata->gpio_vid0)) {