RPC: clarify rpc_run_task error handling

rpc_run_task can only fail if it is not passed in a preallocated task.
However, that is not at all clear with the current code.  So
remove several impossible to occur failure checks.

Signed-off-by: Fred Isaman <iisaman@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index 57d344c..8b5a6b4 100644 (file)
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -636,12 +636,6 @@ struct rpc_task *rpc_run_task(const struct rpc_task_setup *task_setup_data)
        rpc_task_set_client(task, task_setup_data->rpc_client);
        rpc_task_set_rpc_message(task, task_setup_data->rpc_message);
 
-       if (task->tk_status != 0) {
-               int ret = task->tk_status;
-               rpc_put_task(task);
-               return ERR_PTR(ret);
-       }
-
        if (task->tk_action == NULL)
                rpc_call_start(task);
 

diff --git a/net/sunrpc/sched.c b/net/sunrpc/sched.c
index 9310726..5681c6a 100644 (file)
--- a/net/sunrpc/sched.c
+++ b/net/sunrpc/sched.c
@@ -836,12 +836,6 @@ struct rpc_task *rpc_new_task(const struct rpc_task_setup *setup_data)
        }
 
        rpc_init_task(task, setup_data);
-       if (task->tk_status < 0) {
-               int err = task->tk_status;
-               rpc_put_task(task);
-               return ERR_PTR(err);
-       }
-
        task->tk_flags |= flags;
        dprintk("RPC:       allocated task %p\n", task);
        return task;