fddi: 64 bit bug in smt_add_para()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 1 Sep 2012 09:57:40 +0000 (09:57 +0000)
committerDavid S. Miller <davem@tempietto.lan>
Sun, 2 Sep 2012 02:44:13 +0000 (22:44 -0400)
The intent was to set 4 bytes of data so that's why the sp_len is set
to 4 on the next line.  The cast to u_long pointer clears 8 bytes
on 64 bit arches.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@tempietto.lan>
drivers/net/fddi/skfp/pmf.c

index 24d8566..441b4dc 100644 (file)
@@ -673,7 +673,7 @@ void smt_add_para(struct s_smc *smc, struct s_pcon *pcon, u_short para,
                        sm_pm_get_ls(smc,port_to_mib(smc,port))) ;
                break ;
        case SMT_P_REASON :
-               * (u_long *) to = 0 ;
+               *(u32 *)to = 0 ;
                sp_len = 4 ;
                goto sp_done ;
        case SMT_P1033 :                        /* time stamp */