IB/srp: Fix return value check in srp_init_module()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Thu, 14 Aug 2014 00:56:22 +0000 (08:56 +0800)
committerRoland Dreier <roland@purestorage.com>
Thu, 14 Aug 2014 15:57:54 +0000 (08:57 -0700)
In case of error, the function create_workqueue() returns NULL pointer
not ERR_PTR().  The IS_ERR() test in the return value check should be
replaced with NULL test.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Roland Dreier <roland@purestorage.com>
drivers/infiniband/ulp/srp/ib_srp.c

index 7f5ee7f..62d2a18 100644 (file)
@@ -3320,8 +3320,8 @@ static int __init srp_init_module(void)
        }
 
        srp_remove_wq = create_workqueue("srp_remove");
-       if (IS_ERR(srp_remove_wq)) {
-               ret = PTR_ERR(srp_remove_wq);
+       if (!srp_remove_wq) {
+               ret = -ENOMEM;
                goto out;
        }