NFSv4: Fix a potentially Oopsable condition in __nfs_idmap_unregister
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Mon, 26 Aug 2013 21:26:51 +0000 (17:26 -0400)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Fri, 30 Aug 2013 13:19:38 +0000 (09:19 -0400)
Ensure that __nfs_idmap_unregister can be called twice without
consequences.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/idmap.c

index e9b0c59..8b7e94a 100644 (file)
@@ -404,8 +404,10 @@ static struct key_type key_type_id_resolver_legacy = {
 
 static void __nfs_idmap_unregister(struct rpc_pipe *pipe)
 {
-       if (pipe->dentry)
+       if (pipe->dentry) {
                rpc_unlink(pipe->dentry);
+               pipe->dentry = NULL;
+       }
 }
 
 static int __nfs_idmap_register(struct dentry *dir,