drm/nouveau: sizeof() vs ARRAY_SIZE()
authorDan Carpenter <error27@gmail.com>
Mon, 20 Dec 2010 09:26:26 +0000 (12:26 +0300)
committerBen Skeggs <bskeggs@redhat.com>
Tue, 21 Dec 2010 01:53:32 +0000 (11:53 +1000)
ARRAY_SIZE() was intended here, sizeof() is too large.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
drivers/gpu/drm/nouveau/nv50_vram.c

index 47489ed..58e98ad 100644 (file)
@@ -42,7 +42,7 @@ nv50_vram_flags_valid(struct drm_device *dev, u32 tile_flags)
 {
        int type = (tile_flags & NOUVEAU_GEM_TILE_LAYOUT_MASK) >> 8;
 
-       if (likely(type < sizeof(types) && types[type]))
+       if (likely(type < ARRAY_SIZE(types) && types[type]))
                return true;
        return false;
 }