pkt_sched: fq: increase max delay from 125 ms to one second
authorEric Dumazet <edumazet@google.com>
Tue, 25 Nov 2014 16:57:29 +0000 (08:57 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 26 Nov 2014 17:08:04 +0000 (12:08 -0500)
FQ/pacing has a clamp of delay of 125 ms, to avoid some possible harm.

It turns out this delay is too small to allow pacing low rates :
Some ISP setup very aggressive policers as low as 16kbit.

Now TCP stack has spurious rtx prevention, it seems safe to increase
this fixed parameter, without adding a qdisc attribute.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_fq.c

index cbd7e1f..9b05924 100644 (file)
@@ -481,12 +481,11 @@ begin:
                if (likely(rate))
                        do_div(len, rate);
                /* Since socket rate can change later,
-                * clamp the delay to 125 ms.
-                * TODO: maybe segment the too big skb, as in commit
-                * e43ac79a4bc ("sch_tbf: segment too big GSO packets")
+                * clamp the delay to 1 second.
+                * Really, providers of too big packets should be fixed !
                 */
-               if (unlikely(len > 125 * NSEC_PER_MSEC)) {
-                       len = 125 * NSEC_PER_MSEC;
+               if (unlikely(len > NSEC_PER_SEC)) {
+                       len = NSEC_PER_SEC;
                        q->stat_pkts_too_long++;
                }