net: sxgbe: sxgbe_mdio_register() frees the bus
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 1 Apr 2014 13:38:44 +0000 (16:38 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 1 Apr 2014 20:25:52 +0000 (16:25 -0400)
"err" is always zero at this point so we always unregister and free the
mdio_bus before returning success.  This seems like left over code and
I have deleted it.

Fixes: 1edb9ca69e8a ('net: sxgbe: add basic framework for Samsung 10Gb ethernet driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c

index b0eb0a2..01af2cb 100644 (file)
@@ -219,13 +219,6 @@ int sxgbe_mdio_register(struct net_device *ndev)
                }
        }
 
-       if (!err) {
-               netdev_err(ndev, "PHY not found\n");
-               mdiobus_unregister(mdio_bus);
-               mdiobus_free(mdio_bus);
-               goto mdiobus_err;
-       }
-
        priv->mii = mdio_bus;
 
        return 0;