video: xilinxfb: replace devm_request_and_ioremap by devm_ioremap_resource
authorJulia Lawall <Julia.Lawall@lip6.fr>
Mon, 19 Aug 2013 11:20:40 +0000 (13:20 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Fri, 30 Aug 2013 08:45:23 +0000 (11:45 +0300)
Use devm_ioremap_resource instead of devm_request_and_ioremap.

This was done using the semantic patch
scripts/coccinelle/api/devm_ioremap_resource.cocci

The initialization of drvdata->regs_phys was manually moved lower, to take
advantage of the NULL test on res performed by devm_ioremap_resource.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/xilinxfb.c

index f3d4a69..236fd42 100644 (file)
@@ -259,12 +259,12 @@ static int xilinxfb_assign(struct platform_device *pdev,
                struct resource *res;
 
                res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-               drvdata->regs_phys = res->start;
-               drvdata->regs = devm_request_and_ioremap(&pdev->dev, res);
-               if (!drvdata->regs) {
-                       rc = -EADDRNOTAVAIL;
+               drvdata->regs = devm_ioremap_resource(&pdev->dev, res);
+               if (IS_ERR(drvdata->regs)) {
+                       rc = PTR_ERR(drvdata->regs);
                        goto err_region;
                }
+               drvdata->regs_phys = res->start;
        }
 
        /* Allocate the framebuffer memory */