Staging: bcm: Bcmchar: Fix style issues on bcm_char_release()
authorJavier Martinez Canillas <martinez.javier@gmail.com>
Sat, 12 Feb 2011 03:38:23 +0000 (04:38 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 18 Feb 2011 21:21:55 +0000 (13:21 -0800)
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/bcm/Bcmchar.c

index edcd0c0..2a3f64c 100644 (file)
@@ -45,61 +45,55 @@ static int bcm_char_open(struct inode *inode, struct file * filp)
 
 static int bcm_char_release(struct inode *inode, struct file *filp)
 {
-    PPER_TARANG_DATA pTarang, tmp, ptmp;
-       PMINI_ADAPTER Adapter=NULL;
-    struct sk_buff * pkt, * npkt;
+       PPER_TARANG_DATA pTarang, tmp, ptmp;
+       PMINI_ADAPTER Adapter = NULL;
+       struct sk_buff *pkt, *npkt;
 
-    pTarang = (PPER_TARANG_DATA)filp->private_data;
+       pTarang = (PPER_TARANG_DATA)filp->private_data;
 
-    if(pTarang == NULL)
-       {
-       BCM_DEBUG_PRINT(Adapter,DBG_TYPE_PRINTK, 0, 0, "ptarang is null\n");
-       return 0;
+       if (pTarang == NULL) {
+               BCM_DEBUG_PRINT(Adapter, DBG_TYPE_PRINTK, 0, 0,
+                               "ptarang is null\n");
+               return 0;
        }
 
        Adapter = pTarang->Adapter;
 
-    down( &Adapter->RxAppControlQueuelock);
+       down(&Adapter->RxAppControlQueuelock);
 
-    tmp = Adapter->pTarangs;
-    for ( ptmp = NULL; tmp; ptmp = tmp, tmp = tmp->next )
-       {
-        if ( tmp == pTarang )
+       tmp = Adapter->pTarangs;
+       for (ptmp = NULL; tmp; ptmp = tmp, tmp = tmp->next) {
+               if (tmp == pTarang)
                        break;
        }
 
-    if ( tmp )
-       {
-        if ( !ptmp )
-            Adapter->pTarangs = tmp->next;
-        else
-            ptmp->next = tmp->next;
+       if (tmp) {
+               if (!ptmp)
+                       Adapter->pTarangs = tmp->next;
+               else
+                       ptmp->next = tmp->next;
+       } else {
+               up(&Adapter->RxAppControlQueuelock);
+               return 0;
        }
 
-    else
-       {
-       up( &Adapter->RxAppControlQueuelock);
-       return 0;
-       }
-
-    pkt = pTarang->RxAppControlHead;
-    while ( pkt )
-       {
-        npkt = pkt->next;
-        kfree_skb(pkt);
-        pkt = npkt;
+       pkt = pTarang->RxAppControlHead;
+       while (pkt) {
+               npkt = pkt->next;
+               kfree_skb(pkt);
+               pkt = npkt;
        }
 
-    up( &Adapter->RxAppControlQueuelock);
+       up(&Adapter->RxAppControlQueuelock);
 
-    /*Stop Queuing the control response Packets*/
-    atomic_dec(&Adapter->ApplicationRunning);
+       /*Stop Queuing the control response Packets*/
+       atomic_dec(&Adapter->ApplicationRunning);
 
-    kfree(pTarang);
+       kfree(pTarang);
 
        /* remove this filp from the asynchronously notified filp's */
-    filp->private_data = NULL;
-    return 0;
+       filp->private_data = NULL;
+       return 0;
 }
 
 static ssize_t bcm_char_read(struct file *filp, char __user *buf, size_t size, loff_t *f_pos)