vxlan: Wrong type passed to %pIS
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Sat, 7 Feb 2015 02:17:31 +0000 (03:17 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 9 Feb 2015 01:14:40 +0000 (17:14 -0800)
src_ip is a pointer to a union vxlan_addr, one member of which is a
struct sockaddr. Passing a pointer to src_ip is wrong; one should pass
the value of src_ip itself. Since %pIS formally expects something of
type struct sockaddr*, let's pass a pointer to the appropriate union
member, though this of course doesn't change the generated code.

Fixes: e4c7ed415387 ("vxlan: add ipv6 support")
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vxlan.c

index a8c755d..11defbb 100644 (file)
@@ -991,7 +991,7 @@ static bool vxlan_snoop(struct net_device *dev,
                if (net_ratelimit())
                        netdev_info(dev,
                                    "%pM migrated from %pIS to %pIS\n",
-                                   src_mac, &rdst->remote_ip, &src_ip);
+                                   src_mac, &rdst->remote_ip.sa, &src_ip->sa);
 
                rdst->remote_ip = *src_ip;
                f->updated = jiffies;