[NETFILTER]: xt_TCPMSS: remove network triggerable WARN_ON
authorPatrick McHardy <kaber@trash.net>
Fri, 30 Nov 2007 12:58:03 +0000 (23:58 +1100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 30 Nov 2007 12:58:03 +0000 (23:58 +1100)
ipv6_skip_exthdr() returns -1 for invalid packets. don't WARN_ON
that.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
net/netfilter/xt_TCPMSS.c

index 07435a6..8e76d1f 100644 (file)
@@ -174,10 +174,8 @@ xt_tcpmss_target6(struct sk_buff *skb,
 
        nexthdr = ipv6h->nexthdr;
        tcphoff = ipv6_skip_exthdr(skb, sizeof(*ipv6h), &nexthdr);
-       if (tcphoff < 0) {
-               WARN_ON(1);
+       if (tcphoff < 0)
                return NF_DROP;
-       }
        ret = tcpmss_mangle_packet(skb, targinfo, tcphoff,
                                   sizeof(*ipv6h) + sizeof(struct tcphdr));
        if (ret < 0)