net: cdc_ncm: endian convert constants instead of variables
authorBjørn Mork <bjorn@mork.no>
Fri, 1 Nov 2013 10:16:56 +0000 (11:16 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 2 Nov 2013 06:02:04 +0000 (02:02 -0400)
Converting the constants used in these comparisons at build
time instead of converting the variables for every received
frame at run time.

Cc: Alexey Orishko <alexey.orishko@gmail.com>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/cdc_ncm.c

index d49e4c5..83e6d5b 100644 (file)
@@ -882,7 +882,7 @@ int cdc_ncm_rx_verify_nth16(struct cdc_ncm_ctx *ctx, struct sk_buff *skb_in)
 
        nth16 = (struct usb_cdc_ncm_nth16 *)skb_in->data;
 
-       if (le32_to_cpu(nth16->dwSignature) != USB_CDC_NCM_NTH16_SIGN) {
+       if (nth16->dwSignature != cpu_to_le32(USB_CDC_NCM_NTH16_SIGN)) {
                netif_dbg(dev, rx_err, dev->net,
                          "invalid NTH16 signature <%#010x>\n",
                          le32_to_cpu(nth16->dwSignature));
@@ -972,7 +972,7 @@ next_ndp:
 
        ndp16 = (struct usb_cdc_ncm_ndp16 *)(skb_in->data + ndpoffset);
 
-       if (le32_to_cpu(ndp16->dwSignature) != USB_CDC_NCM_NDP16_NOCRC_SIGN) {
+       if (ndp16->dwSignature != cpu_to_le32(USB_CDC_NCM_NDP16_NOCRC_SIGN)) {
                netif_dbg(dev, rx_err, dev->net,
                          "invalid DPT16 signature <%#010x>\n",
                          le32_to_cpu(ndp16->dwSignature));