ktest: Use oldnoconfig instead of yes command

Running the command "yes ''" through the make oldconfig may enable
things we do not want enabled. If something is default enabled, the
yes command with '' as an argument will enable it.

Use oldnoconfig, which runs everything as if 'no' was used.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index a7e86e3..5bd0075 100644 (file)
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -694,7 +694,6 @@ sub check_buildlog {
 sub build {
     my ($type) = @_;
     my $defconfig = "";
-    my $append = "";
 
     unlink $buildlog;
 
@@ -707,7 +706,7 @@ sub build {
 
     # old config can ask questions
     if ($type eq "oldconfig") {
-       $append = "yes ''|";
+       $type = "oldnoconfig";
 
        # allow for empty configs
        run_command "touch $outputdir/.config";
@@ -737,7 +736,7 @@ sub build {
        $defconfig = "KCONFIG_ALLCONFIG=$minconfig";
     }
 
-    run_command "$append $defconfig $make $type" or
+    run_command "$defconfig $make $type" or
        dodie "failed make config";
 
     $redirect = "$buildlog";