spi/bcm63xx-hsspi: fix pm sleep support
authorJonas Gorski <jogo@openwrt.org>
Tue, 17 Dec 2013 20:44:48 +0000 (21:44 +0100)
committerMark Brown <broonie@linaro.org>
Tue, 17 Dec 2013 22:32:17 +0000 (22:32 +0000)
Use the right CONFIG symbol to guard, properly (un)preprare clocks on
suspend/resume, and check the result of it.

Signed-off-by: Jonas Gorski <jogo@openwrt.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/spi/spi-bcm63xx-hsspi.c

index 1721ea9..b528f9f 100644 (file)
@@ -425,14 +425,14 @@ static int bcm63xx_hsspi_remove(struct platform_device *pdev)
        return 0;
 }
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 static int bcm63xx_hsspi_suspend(struct device *dev)
 {
        struct spi_master *master = dev_get_drvdata(dev);
        struct bcm63xx_hsspi *bs = spi_master_get_devdata(master);
 
        spi_master_suspend(master);
-       clk_disable(bs->clk);
+       clk_disable_unprepare(bs->clk);
 
        return 0;
 }
@@ -441,30 +441,27 @@ static int bcm63xx_hsspi_resume(struct device *dev)
 {
        struct spi_master *master = dev_get_drvdata(dev);
        struct bcm63xx_hsspi *bs = spi_master_get_devdata(master);
+       int ret;
+
+       ret = clk_prepare_enable(bs->clk);
+       if (ret)
+               return ret;
 
-       clk_enable(bs->clk);
        spi_master_resume(master);
 
        return 0;
 }
+#endif
 
 static const struct dev_pm_ops bcm63xx_hsspi_pm_ops = {
-       .suspend        = bcm63xx_hsspi_suspend,
-       .resume         = bcm63xx_hsspi_resume,
+       SET_SYSTEM_SLEEP_PM_OPS(bcm63xx_hsspi_suspend, bcm63xx_hsspi_resume)
 };
 
-#define BCM63XX_HSSPI_PM_OPS   (&bcm63xx_hsspi_pm_ops)
-#else
-#define BCM63XX_HSSPI_PM_OPS   NULL
-#endif
-
-
-
 static struct platform_driver bcm63xx_hsspi_driver = {
        .driver = {
                .name   = "bcm63xx-hsspi",
                .owner  = THIS_MODULE,
-               .pm     = BCM63XX_HSSPI_PM_OPS,
+               .pm     = &bcm63xx_hsspi_pm_ops,
        },
        .probe          = bcm63xx_hsspi_probe,
        .remove         = bcm63xx_hsspi_remove,