keyspan_pda: Use string flip functions
authorAlan Cox <alan@redhat.com>
Tue, 22 Jul 2008 10:13:51 +0000 (11:13 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 22 Jul 2008 20:03:25 +0000 (13:03 -0700)
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/usb/serial/keyspan_pda.c

index b60012c..040040a 100644 (file)
@@ -207,7 +207,6 @@ static void keyspan_pda_rx_interrupt(struct urb *urb)
        struct usb_serial_port *port = urb->context;
        struct tty_struct *tty = port->port.tty;
        unsigned char *data = urb->transfer_buffer;
        struct usb_serial_port *port = urb->context;
        struct tty_struct *tty = port->port.tty;
        unsigned char *data = urb->transfer_buffer;
-       int i;
        int retval;
        int status = urb->status;
        struct keyspan_pda_private *priv;
        int retval;
        int status = urb->status;
        struct keyspan_pda_private *priv;
@@ -235,8 +234,8 @@ static void keyspan_pda_rx_interrupt(struct urb *urb)
        case 0:
                /* rest of message is rx data */
                if (urb->actual_length) {
        case 0:
                /* rest of message is rx data */
                if (urb->actual_length) {
-                       for (i = 1; i < urb->actual_length ; ++i)
-                               tty_insert_flip_char(tty, data[i], 0);
+                       tty_insert_flip_string(tty, data + 1,
+                                               urb->actual_length - 1);
                        tty_flip_buffer_push(tty);
                }
                break;
                        tty_flip_buffer_push(tty);
                }
                break;