NFS: Always trust the PageUptodate flag when we have a delegation
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Sun, 29 Apr 2012 16:50:01 +0000 (12:50 -0400)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Tue, 1 May 2012 19:42:41 +0000 (15:42 -0400)
We can always use the optimal full page write if we know that we
hold a delegation.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/write.c

index d1e4f81..6f263da 100644 (file)
@@ -850,10 +850,14 @@ int nfs_flush_incompatible(struct file *file, struct page *page)
  * the PageUptodate() flag. In this case, we will need to turn off
  * write optimisations that depend on the page contents being correct.
  */
-static int nfs_write_pageuptodate(struct page *page, struct inode *inode)
+static bool nfs_write_pageuptodate(struct page *page, struct inode *inode)
 {
-       return PageUptodate(page) &&
-               !(NFS_I(inode)->cache_validity & (NFS_INO_REVAL_PAGECACHE|NFS_INO_INVALID_DATA));
+       if (nfs_have_delegated_attributes(inode))
+               goto out;
+       if (NFS_I(inode)->cache_validity & NFS_INO_REVAL_PAGECACHE)
+               return false;
+out:
+       return PageUptodate(page) != 0;
 }
 
 /*