x86/acpi: Fix incorrect sanity check in acpi_register_lapic()
authorTang Chen <tangchen@cn.fujitsu.com>
Tue, 23 Jul 2013 08:00:19 +0000 (16:00 +0800)
committerIngo Molnar <mingo@kernel.org>
Tue, 23 Jul 2013 08:08:16 +0000 (10:08 +0200)
We wanted to check if the APIC ID is out of range. It should be:

if (id >= MAX_LOCAL_APIC)

There's no known bad effect of this bug.

Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
Reviewed-by: Len Brown <len.brown@intel.com>
Cc: pavel@ucw.cz
Cc: rjw@sisk.pl
Link: http://lkml.kernel.org/r/1374566419-21120-1-git-send-email-tangchen@cn.fujitsu.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/acpi/boot.c

index 2627a81..872a2d2 100644 (file)
@@ -199,7 +199,7 @@ static void acpi_register_lapic(int id, u8 enabled)
 {
        unsigned int ver = 0;
 
-       if (id >= (MAX_LOCAL_APIC-1)) {
+       if (id >= MAX_LOCAL_APIC) {
                printk(KERN_INFO PREFIX "skipped apicid that is too big\n");
                return;
        }