drivers/rtc/rtc-pcf2123.c: fix error return code in pcf2123_probe()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Mon, 29 Apr 2013 23:21:07 +0000 (16:21 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 30 May 2013 13:35:15 +0000 (14:35 +0100)
commit 35623715818dfa720cccf99cd280dcbb4b78da23 upstream.

Fix to return -ENODEV in the chip not found error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Cc: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/rtc/rtc-pcf2123.c

index 2ee3bbf..62e1b2c 100644 (file)
@@ -264,6 +264,7 @@ static int __devinit pcf2123_probe(struct spi_device *spi)
 
        if (!(rxbuf[0] & 0x20)) {
                dev_err(&spi->dev, "chip not found\n");
+               ret = -ENODEV;
                goto kfree_exit;
        }