xhci: Redundant check in xhci_check_args for xhci->devs
authorsifram.rajas@gmail.com <sifram.rajas@gmail.com>
Fri, 2 Sep 2011 18:06:00 +0000 (11:06 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 9 Sep 2011 22:52:54 +0000 (15:52 -0700)
The xhci_hcd->devs is an array of pointers rather than pointer to pointer.
Hence this check is not required.

Signed-off-by: Sifram Rajas <Sifram Rajas sifram.rajas@gmail.com>
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/host/xhci.c

index 6440bd2..dd0dc15 100644 (file)
@@ -945,8 +945,7 @@ static int xhci_check_args(struct usb_hcd *hcd, struct usb_device *udev,
                return -ENODEV;
 
        if (check_virt_dev) {
-               if (!udev->slot_id || !xhci->devs
-                       || !xhci->devs[udev->slot_id]) {
+               if (!udev->slot_id || !xhci->devs[udev->slot_id]) {
                        printk(KERN_DEBUG "xHCI %s called with unaddressed "
                                                "device\n", func);
                        return -EINVAL;