Ext2: remove the static function release_blocks to optimize the kernel
authorWang Shilong <wangsl-fnst@cn.fujitsu.com>
Thu, 7 Feb 2013 14:57:54 +0000 (22:57 +0800)
committerJan Kara <jack@suse.cz>
Thu, 7 Feb 2013 15:44:56 +0000 (16:44 +0100)
Because the static function 'release_blocks' is only called
when releasing blocks,it will be more simple and efficient to
call the function 'percpu_counter_add' directly.

Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/ext2/balloc.c

index 132da4c..9f9992b 100644 (file)
@@ -159,15 +159,6 @@ read_block_bitmap(struct super_block *sb, unsigned int block_group)
        return bh;
 }
 
        return bh;
 }
 
-static void release_blocks(struct super_block *sb, int count)
-{
-       if (count) {
-               struct ext2_sb_info *sbi = EXT2_SB(sb);
-
-               percpu_counter_add(&sbi->s_freeblocks_counter, count);
-       }
-}
-
 static void group_adjust_blocks(struct super_block *sb, int group_no,
        struct ext2_group_desc *desc, struct buffer_head *bh, int count)
 {
 static void group_adjust_blocks(struct super_block *sb, int group_no,
        struct ext2_group_desc *desc, struct buffer_head *bh, int count)
 {
@@ -569,7 +560,7 @@ do_more:
 error_return:
        brelse(bitmap_bh);
        if (freed) {
 error_return:
        brelse(bitmap_bh);
        if (freed) {
-               release_blocks(sb, freed);
+               percpu_counter_add(&sbi->s_freeblocks_counter, freed);
                dquot_free_block_nodirty(inode, freed);
                mark_inode_dirty(inode);
        }
                dquot_free_block_nodirty(inode, freed);
                mark_inode_dirty(inode);
        }