sh: fixed cmpxchg gRB version
authorGiuseppe CAVALLARO <peppe.cavallaro@st.com>
Mon, 25 Jan 2010 15:12:07 +0000 (16:12 +0100)
committerPaul Mundt <lethal@linux-sh.org>
Wed, 27 Jan 2010 13:36:25 +0000 (22:36 +0900)
This patch fixes a bug within the cmpxchg GRB version.

A problem was notices while running some tests to stress
the priority inheritance, for example pi_stress
(http://rt.wiki.kernel.org/index.php/PI_Mutex_Test).

Also, without this patch, after applying the latest work to
consolidate atomic_cmpxchg() definitions (commit:
8c0b8139c87cfe8b95c6e763b4ca3190aa9b1ad0)
the Kernel doesn't boot at all.

Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Signed-off-by: Stuart Menefy <stuart.menefy@st.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
arch/sh/include/asm/cmpxchg-grb.h

index e2681ab..4676bf5 100644 (file)
@@ -57,11 +57,10 @@ static inline unsigned long __cmpxchg_u32(volatile int *m, unsigned long old,
                "   mov.l  @%1,   %0      \n\t" /* load  old value */
                "   cmp/eq  %0,   %2      \n\t"
                "   bf            1f      \n\t" /* if not equal */
-               "   mov.l   %2,   @%1     \n\t" /* store new value */
+               "   mov.l   %3,   @%1     \n\t" /* store new value */
                "1: mov     r1,   r15     \n\t" /* LOGOUT */
-               : "=&r" (retval),
-                 "+r"  (m)
-               : "r"   (new)
+               : "=&r" (retval)
+               :  "r"  (m), "r"  (old), "r"  (new)
                : "memory" , "r0", "r1", "t");
 
        return retval;