quota: Move down dqptr_sem read after initializing default warn[] type at __dquot_all...
authorJeff Liu <jeff.liu@oracle.com>
Wed, 18 Jul 2012 04:12:41 +0000 (12:12 +0800)
committerJan Kara <jack@suse.cz>
Tue, 14 Aug 2012 22:22:57 +0000 (00:22 +0200)
sb->s_dqopt->dqptr_sem is used to serialize ops using pointers from inode to
dquots.  But for __dquot_alloc_space(), it could be safely moved down after the
default warn[] array got initialized.

Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/quota/dquot.c

index 36a29b7..c495a30 100644 (file)
@@ -1589,10 +1589,10 @@ int __dquot_alloc_space(struct inode *inode, qsize_t number, int flags)
                goto out;
        }
 
-       down_read(&sb_dqopt(inode->i_sb)->dqptr_sem);
        for (cnt = 0; cnt < MAXQUOTAS; cnt++)
                warn[cnt].w_type = QUOTA_NL_NOWARN;
 
+       down_read(&sb_dqopt(inode->i_sb)->dqptr_sem);
        spin_lock(&dq_data_lock);
        for (cnt = 0; cnt < MAXQUOTAS; cnt++) {
                if (!dquots[cnt])