mtd/nand/sh_flctl: Replace the dangerous mtd_to_flctl macro
authorFerenc Wagner <wferi@niif.hu>
Tue, 23 Mar 2010 17:09:09 +0000 (18:09 +0100)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Mon, 10 May 2010 13:22:19 +0000 (14:22 +0100)
The original macro worked only when applied to variables named 'mtd'.
While this could have been fixed by simply renaming the macro argument,
a more type-safe replacement is preferred.

Signed-off-by: Ferenc Wagner <wferi@niif.hu>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
include/linux/mtd/sh_flctl.h

index ab77609..178b5c2 100644 (file)
 #define INIT_FL4ECCRESULT_VAL  0x03FF03FF
 #define LOOP_TIMEOUT_MAX       0x00010000
 
-#define mtd_to_flctl(mtd)      container_of(mtd, struct sh_flctl, mtd)
+static inline struct sh_flctl *mtd_to_flctl(struct mtd_info *mtdinfo)
+{
+       return container_of(mtdinfo, struct sh_flctl, mtd);
+}
 
 struct sh_flctl {
        struct mtd_info         mtd;