usb: gadget: f_fs: Remove lock is held before freeing checks
authorAndi Kleen <ak@linux.intel.com>
Fri, 16 Mar 2012 19:01:02 +0000 (12:01 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 16 Mar 2012 20:30:10 +0000 (13:30 -0700)
lock debugging already supports this, no need to do it explicitely.

Cc: balbi@ti.com
Cc: gregkh@linuxfoundation.org
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/f_fs.c

index 7e2216f..7f445ec 100644 (file)
@@ -1258,9 +1258,7 @@ static void ffs_data_put(struct ffs_data *ffs)
        if (unlikely(atomic_dec_and_test(&ffs->ref))) {
                pr_info("%s(): freeing\n", __func__);
                ffs_data_clear(ffs);
        if (unlikely(atomic_dec_and_test(&ffs->ref))) {
                pr_info("%s(): freeing\n", __func__);
                ffs_data_clear(ffs);
-               BUG_ON(mutex_is_locked(&ffs->mutex) ||
-                      spin_is_locked(&ffs->ev.waitq.lock) ||
-                      waitqueue_active(&ffs->ev.waitq) ||
+               BUG_ON(waitqueue_active(&ffs->ev.waitq) ||
                       waitqueue_active(&ffs->ep0req_completion.wait));
                kfree(ffs);
        }
                       waitqueue_active(&ffs->ep0req_completion.wait));
                kfree(ffs);
        }