jffs2: S_ISLNK(mode & S_IFMT) is pointless
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 24 Jul 2011 21:11:33 +0000 (17:11 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 26 Jul 2011 17:00:35 +0000 (13:00 -0400)
it's S_ISLNK(mode), TYVM...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/jffs2/fs.c

index eeead33..b81b35d 100644 (file)
@@ -80,7 +80,7 @@ int jffs2_do_setattr (struct inode *inode, struct iattr *iattr)
                                  ALLOC_NORMAL, JFFS2_SUMMARY_INODE_SIZE);
        if (ret) {
                jffs2_free_raw_inode(ri);
-               if (S_ISLNK(inode->i_mode & S_IFMT))
+               if (S_ISLNK(inode->i_mode))
                         kfree(mdata);
                return ret;
        }