mct_u232: Fix use of uninitialized pointer in mct_u323_startup()
authorBen Hutchings <ben@decadent.org.uk>
Mon, 6 Nov 2017 02:50:25 +0000 (02:50 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 11 Nov 2017 13:34:49 +0000 (13:34 +0000)
My backport of commit 4e9a0b05257f "USB: mct_u232: add sanity checking in
probe" incorrectly added a dev_err() call using port->dev before 'port' was
initialised.  Use the 'serial' parameter to look up the device instead.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/serial/mct_u232.c

index ed8694b..8901b8d 100644 (file)
@@ -449,7 +449,7 @@ static int mct_u232_startup(struct usb_serial *serial)
 
        /* check first to simplify error handling */
        if (!serial->port[1] || !serial->port[1]->interrupt_in_urb) {
-               dev_err(&port->dev, "expected endpoint missing\n");
+               dev_err(&serial->dev->dev, "expected endpoint missing\n");
                return -ENODEV;
        }