[IPV4]: Remove unnecessary test for the loopback device from inetdev_destroy
authorEric W. Biederman <ebiederm@xmission.com>
Thu, 27 Sep 2007 05:09:25 +0000 (22:09 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Wed, 10 Oct 2007 23:52:48 +0000 (16:52 -0700)
Currently we never call unregister_netdev for the loopback device so
it is impossible for us to reach inetdev_destroy with the loopback
device.  So the test in inetdev_destroy is unnecessary.

Further when testing with my network namespace patches removing
unregistering the loopback device and calling inetdev_destroy works
fine so there appears to be no reason for avoiding unregistering the
loopback device.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/devinet.c

index affea9b..e7f2b02 100644 (file)
@@ -203,8 +203,6 @@ static void inetdev_destroy(struct in_device *in_dev)
        ASSERT_RTNL();
 
        dev = in_dev->dev;
-       if (dev == loopback_dev)
-               return;
 
        in_dev->dead = 1;