Smack: change rule cap check
authorCasey Schaufler <casey@schaufler-ca.com>
Thu, 19 Dec 2013 21:23:26 +0000 (13:23 -0800)
committerCasey Schaufler <casey@schaufler-ca.com>
Mon, 23 Dec 2013 23:57:43 +0000 (15:57 -0800)
smk_write_change_rule() is calling capable rather than
the more correct smack_privileged(). This allows for setting
rules in violation of the onlycap facility. This is the
simple repair.

Targeted for git://git.gitorious.org/smack-next/kernel.git

Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
security/smack/smackfs.c

index f5a6bb8..3198cfe 100644 (file)
@@ -2152,7 +2152,7 @@ static ssize_t smk_write_change_rule(struct file *file, const char __user *buf,
        /*
         * Must have privilege.
         */
-       if (!capable(CAP_MAC_ADMIN))
+       if (!smack_privileged(CAP_MAC_ADMIN))
                return -EPERM;
 
        return smk_write_rules_list(file, buf, count, ppos, NULL, NULL,