i7core_edac: Fix the logic in i7core_remove()
authorHidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Fri, 20 Aug 2010 07:24:18 +0000 (04:24 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sun, 24 Oct 2010 13:20:38 +0000 (11:20 -0200)
commit 47251b4d960bdfa648b0d06dbc6d445f41cb3906 have changed
the logic for unexplained reasons.  It looks strange that it
can release i7core_dev without calling i7core_put_devices()
that releases i7core_dev->pdev.

Fix the part.

Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/edac/i7core_edac.c

index a76a4c0..d64ac2c 100644 (file)
@@ -2095,9 +2095,9 @@ static void __devexit i7core_remove(struct pci_dev *pdev)
 
                        /* Release PCI resources */
                        i7core_put_devices(i7core_dev);
+                       list_del(&i7core_dev->list);
+                       kfree(i7core_dev);
                }
-               list_del(&i7core_dev->list);
-               kfree(i7core_dev);
        }
        probed--;