omfs: fix (mode & S_IFDIR) abuse
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 26 Jul 2011 06:34:33 +0000 (02:34 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 26 Jul 2011 17:05:28 +0000 (13:05 -0400)
granted, on a filesystem that has only regular files and directories
it happens to work, but really should be S_ISDIR(mode)...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/omfs/dir.c

index 3b8d397..98e5442 100644 (file)
@@ -93,7 +93,7 @@ int omfs_make_empty(struct inode *inode, struct super_block *sb)
 
        memset(bh->b_data, 0, sizeof(struct omfs_inode));
 
-       if (inode->i_mode & S_IFDIR) {
+       if (S_ISDIR(inode->i_mode)) {
                memset(&bh->b_data[OMFS_DIR_START], 0xff,
                        sbi->s_sys_blocksize - OMFS_DIR_START);
        } else