NET: pch, fix use after free

Stanse found that pch_gbe_xmit_frame uses skb after it is freed. Fix
that.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Masayuki Ohtake <masa-korg@dsn.okisemi.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/pch_gbe/pch_gbe_main.c b/drivers/net/pch_gbe/pch_gbe_main.c
index 53c56cf..e44644f 100644 (file)
--- a/drivers/net/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/pch_gbe/pch_gbe_main.c
@@ -1847,9 +1847,9 @@ static int pch_gbe_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
        unsigned long flags;
 
        if (unlikely(skb->len > (adapter->hw.mac.max_frame_size - 4))) {
-               dev_kfree_skb_any(skb);
                pr_err("Transfer length Error: skb len: %d > max: %d\n",
                       skb->len, adapter->hw.mac.max_frame_size);
+               dev_kfree_skb_any(skb);
                adapter->stats.tx_length_errors++;
                return NETDEV_TX_OK;
        }