ACPI: make acpi_pad /sys output more readable
authorNaga Chumbalkar <nagananda.chumbalkar@hp.com>
Wed, 2 Feb 2011 23:26:58 +0000 (23:26 +0000)
committerLen Brown <len.brown@intel.com>
Wed, 23 Mar 2011 05:34:15 +0000 (01:34 -0400)
Make /sys output from acpi_pad more readable.

Before the fix:
# cat idlecpus idlepct rrtime
00000000510

After the fix:
# cat idlecpus idlepct rrtime
00000000
5
10

Signed-off-by: Naga Chumbalkar <nagananda.chumbalkar@hp.com>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/acpi/acpi_pad.c

index 6afceb3..474be3a 100644 (file)
@@ -298,7 +298,7 @@ static ssize_t acpi_pad_rrtime_store(struct device *dev,
 static ssize_t acpi_pad_rrtime_show(struct device *dev,
        struct device_attribute *attr, char *buf)
 {
-       return scnprintf(buf, PAGE_SIZE, "%d", round_robin_time);
+       return scnprintf(buf, PAGE_SIZE, "%d\n", round_robin_time);
 }
 static DEVICE_ATTR(rrtime, S_IRUGO|S_IWUSR,
        acpi_pad_rrtime_show,
@@ -321,7 +321,7 @@ static ssize_t acpi_pad_idlepct_store(struct device *dev,
 static ssize_t acpi_pad_idlepct_show(struct device *dev,
        struct device_attribute *attr, char *buf)
 {
-       return scnprintf(buf, PAGE_SIZE, "%d", idle_pct);
+       return scnprintf(buf, PAGE_SIZE, "%d\n", idle_pct);
 }
 static DEVICE_ATTR(idlepct, S_IRUGO|S_IWUSR,
        acpi_pad_idlepct_show,
@@ -342,8 +342,11 @@ static ssize_t acpi_pad_idlecpus_store(struct device *dev,
 static ssize_t acpi_pad_idlecpus_show(struct device *dev,
        struct device_attribute *attr, char *buf)
 {
-       return cpumask_scnprintf(buf, PAGE_SIZE,
-               to_cpumask(pad_busy_cpus_bits));
+       int n = 0;
+       n = cpumask_scnprintf(buf, PAGE_SIZE-2, to_cpumask(pad_busy_cpus_bits));
+       buf[n++] = '\n';
+       buf[n] = '\0';
+       return n;
 }
 static DEVICE_ATTR(idlecpus, S_IRUGO|S_IWUSR,
        acpi_pad_idlecpus_show,