s2io: fix warning in drivers/net/s2io.c
authorIngo Molnar <mingo@elte.hu>
Wed, 26 Nov 2008 00:47:35 +0000 (16:47 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 26 Nov 2008 00:47:35 +0000 (16:47 -0800)
this warning:

  drivers/net/s2io.c: In function ‘rx_intr_handler’:
  drivers/net/s2io.c:7369: warning: ‘lro’ may be used uninitialized in this function

triggers because GCC does not recognize the (correct) error flow
between:

 - s2io_club_tcp_session()and 'lro'

Annotate it.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/s2io.c

index a464205..1b489df 100644 (file)
@@ -7367,7 +7367,7 @@ static int rx_osm_handler(struct ring_info *ring_data, struct RxD_t * rxdp)
        int ring_no = ring_data->ring_no;
        u16 l3_csum, l4_csum;
        unsigned long long err = rxdp->Control_1 & RXD_T_CODE;
-       struct lro *lro;
+       struct lro *uninitialized_var(lro);
        u8 err_mask;
 
        skb->dev = dev;