ext4: Remove outdated comment about lock_super()
authorTheodore Ts'o <tytso@mit.edu>
Sat, 25 Apr 2009 19:48:07 +0000 (15:48 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 25 Apr 2009 19:48:07 +0000 (15:48 -0400)
ext4_fill_super() is no longer called by read_super(), and it is no
longer called with the superblock locked.  The
unlock_super()/lock_super() is no longer present, so this comment is
entirely superfluous.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/super.c

index fcd7b24..e3b35f2 100644 (file)
@@ -2828,14 +2828,6 @@ no_journal:
                goto failed_mount4;
        };
 
-       /*
-        * akpm: core read_super() calls in here with the superblock locked.
-        * That deadlocks, because orphan cleanup needs to lock the superblock
-        * in numerous places.  Here we just pop the lock - it's relatively
-        * harmless, because we are now ready to accept write_super() requests,
-        * and aviro says that's the only reason for hanging onto the
-        * superblock lock.
-        */
        EXT4_SB(sb)->s_mount_state |= EXT4_ORPHAN_FS;
        ext4_orphan_cleanup(sb, es);
        EXT4_SB(sb)->s_mount_state &= ~EXT4_ORPHAN_FS;