net/mac80211: Correct size given to memset
authorJulia Lawall <julia@diku.dk>
Wed, 9 Dec 2009 19:25:59 +0000 (20:25 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 10 Dec 2009 21:09:52 +0000 (16:09 -0500)
Memset should be given the size of the structure, not the size of the pointer.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
type T;
T *x;
expression E;
@@

memset(x, E, sizeof(
+ *
 x))
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/mesh.c

index c0fe464..6a43314 100644 (file)
@@ -427,7 +427,7 @@ int ieee80211_new_mesh_header(struct ieee80211s_hdr *meshhdr,
                char *addr5, char *addr6)
 {
        int aelen = 0;
-       memset(meshhdr, 0, sizeof(meshhdr));
+       memset(meshhdr, 0, sizeof(*meshhdr));
        meshhdr->ttl = sdata->u.mesh.mshcfg.dot11MeshTTL;
        put_unaligned(cpu_to_le32(sdata->u.mesh.mesh_seqnum), &meshhdr->seqnum);
        sdata->u.mesh.mesh_seqnum++;