mfd: Fix pcf50633 bitfield logic in interrupt handler
authorLars-Peter Clausen <lars@metafoo.de>
Wed, 12 May 2010 00:10:53 +0000 (02:10 +0200)
committerSamuel Ortiz <sameo@linux.intel.com>
Thu, 27 May 2010 23:37:48 +0000 (01:37 +0200)
Those constants are alreay bitfields.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/mfd/pcf50633-core.c

index 5439282..37618b2 100644 (file)
@@ -354,18 +354,18 @@ static void pcf50633_irq_worker(struct work_struct *work)
        if (pcf_int[0] & (PCF50633_INT1_USBINS | PCF50633_INT1_USBREM)) {
                chgstat = pcf50633_reg_read(pcf, PCF50633_REG_MBCS2);
                if (chgstat & (0x3 << 4))
-                       pcf_int[0] &= ~(1 << PCF50633_INT1_USBREM);
+                       pcf_int[0] &= ~PCF50633_INT1_USBREM;
                else
-                       pcf_int[0] &= ~(1 << PCF50633_INT1_USBINS);
+                       pcf_int[0] &= ~PCF50633_INT1_USBINS;
        }
 
        /* Make sure only one of ADPINS or ADPREM is set */
        if (pcf_int[0] & (PCF50633_INT1_ADPINS | PCF50633_INT1_ADPREM)) {
                chgstat = pcf50633_reg_read(pcf, PCF50633_REG_MBCS2);
                if (chgstat & (0x3 << 4))
-                       pcf_int[0] &= ~(1 << PCF50633_INT1_ADPREM);
+                       pcf_int[0] &= ~PCF50633_INT1_ADPREM;
                else
-                       pcf_int[0] &= ~(1 << PCF50633_INT1_ADPINS);
+                       pcf_int[0] &= ~PCF50633_INT1_ADPINS;
        }
 
        dev_dbg(pcf->dev, "INT1=0x%02x INT2=0x%02x INT3=0x%02x "