PCI: pciehp: remove number field
authorKenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Tue, 15 Sep 2009 08:31:16 +0000 (17:31 +0900)
committerJesse Barnes <jbarnes@virtuousgeek.org>
Thu, 17 Sep 2009 17:06:36 +0000 (10:06 -0700)
Since slot_cap field in struct controller contains physical slot
number informationq, we don't need number field in struct slot.

Acked-by: Alex Chiang <achiang@hp.com>
Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
drivers/pci/hotplug/pciehp.h
drivers/pci/hotplug/pciehp_core.c
drivers/pci/hotplug/pciehp_hpc.c

index b7054cb..b20a38d 100644 (file)
@@ -73,7 +73,6 @@ do {                                                                  \
 #define SLOT_NAME_SIZE 10
 struct slot {
        u8 state;
-       u32 number;
        struct controller *ctrl;
        struct hotplug_slot *hotplug_slot;
        struct delayed_work work;       /* work for button event */
index 2c6d94f..bc23471 100644 (file)
@@ -121,11 +121,11 @@ static int init_slot(struct controller *ctrl)
        hotplug->release = &release_slot;
        hotplug->ops = &pciehp_hotplug_slot_ops;
        slot->hotplug_slot = hotplug;
-       snprintf(name, SLOT_NAME_SIZE, "%u", slot->number);
+       snprintf(name, SLOT_NAME_SIZE, "%u", PSN(ctrl));
 
        ctrl_dbg(ctrl, "Registering domain:bus:dev=%04x:%02x:00 sun=%x\n",
                 pci_domain_nr(ctrl->pcie->port->subordinate),
-                ctrl->pcie->port->subordinate->number, slot->number);
+                ctrl->pcie->port->subordinate->number, PSN(ctrl));
        retval = pci_hp_register(hotplug,
                                 ctrl->pcie->port->subordinate, 0, name);
        if (retval) {
index 8c34e84..9ef4605 100644 (file)
@@ -901,7 +901,6 @@ static int pcie_init_slot(struct controller *ctrl)
                return -ENOMEM;
 
        slot->ctrl = ctrl;
-       slot->number = PSN(ctrl);
        mutex_init(&slot->lock);
        INIT_DELAYED_WORK(&slot->work, pciehp_queue_pushbutton_work);
        ctrl->slot = slot;