ACPI / dock: Fix acpi_bus_get_device() check in drivers/acpi/dock.c
authorYasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Thu, 31 Jan 2013 03:23:53 +0000 (03:23 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sat, 2 Feb 2013 19:10:23 +0000 (20:10 +0100)
acpi_bus_get_device() returns int not acpi_status.

The patch change not to apply ACPI_SUCCESS() to the return value of
acpi_bus_get_device().

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/dock.c

index 78648f8..68d720a 100644 (file)
@@ -825,7 +825,7 @@ static ssize_t show_docked(struct device *dev,
 
        struct dock_station *dock_station = dev->platform_data;
 
-       if (ACPI_SUCCESS(acpi_bus_get_device(dock_station->handle, &tmp)))
+       if (!acpi_bus_get_device(dock_station->handle, &tmp))
                return snprintf(buf, PAGE_SIZE, "1\n");
        return snprintf(buf, PAGE_SIZE, "0\n");
 }